Expand support for PackExpansion type in requirements machine #84857
+210 −79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Types where pack expansion required nested subsitution could cause the compiler to crash rather than properly expanding the pack, both for populated types and infinitly expanding types which should generate an error. This expands the support for these to generate errors orpopulated types, and correspondingly expands the test suite
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Types where pack expansion required nested subsitution could cause the compiler to crash rather than properly expanding the pack, both for populated types and infinitly expanding types which should generate an error.
This expands the support for these to generate errors or populated types, and correspondingly expands the test suite
This is a draft for early comments. The code is not yet complete for populated types, requires clean up, and tests.