Skip to content

[Parse] Avoid setting closure in SourceLoc if missing #84855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Parse] Avoid setting closure in SourceLoc if missing #84855

wants to merge 1 commit into from
+45 −9

Conversation

hamishknight
Copy link
Contributor

@hamishknight hamishknight commented Oct 13, 2025 •
edited
Loading

Clients should be able to handle closures without a valid in SourceLoc, let's avoid setting it to a recovery location. This avoids crashing in cases where we set an in loc that's after the closure's end loc, fixing a stress tester regression from #84278.
@hamishknight
[Parse] Avoid setting closure in SourceLoc if missing
b83cf1e 
Clients should be able to handle closures without a valid `in` SourceLoc, let's avoid setting it to a recovery location. This avoids crashing in cases where we set an `in` loc that's after the closure's end loc.
@hamishknight
Copy link
Contributor Author

@swift-ci please test
@hamishknight
Copy link
Contributor Author

@swift-ci please SourceKit stress test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@hamishknight @rintaro