Use isAvailable when reading simctl device JSON #171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
`swift-mode:debug-ios-app` was failing because no simulator could be configured; the output of `simctl` was not as expected. The `availability` field of the `device` object had been deprecated and was removed as of Xcode 11 (see https://developer.apple.com/documentation/xcode-release-notes/xcode-11-release-notes heading "Resolved Issues") in favor of a boolean `isAvailable`.
| I'm not sure it's possible to add tests for this -- is the CI running on a Mac with Xcode installed? |
| Thank you for your PR. It works fine. The CI is configured only for Linux machines for now. It is technically possible to setup CI for macOS with iOS simulators because GitHub Action provides macOS images with Xcode. |
| Glad to be helpful! 🙂 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
swift-mode:debug-ios-appwas failing because no simulator couldbe configured; the output of
simctlwas not as expected.The
availabilityfield of thedeviceobject had been deprecatedand was removed as of Xcode 11 (see
https://developer.apple.com/documentation/xcode-release-notes/xcode-11-release-notes
heading "Resolved Issues") in favor of a boolean
isAvailable.