Add unit tests for org.rapidpm.frp.model #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
These tests were written using Diffblue Cover.
These tests were written using Diffblue Cover.
These tests were written using Diffblue Cover.
These tests were written using Diffblue Cover.
These tests were written using Diffblue Cover.
These tests were written using Diffblue Cover.
These tests were written using Diffblue Cover.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Hi,
I've ran your repository through the JaCoCo code coverage tool, which reported that you had
38.5%line coverage from your existing unit tests.From this, I've written some sample tests with the help of Diffblue Cover, for the following previously-uncovered classes:
org.rapidpm.frp.model.Singleorg.rapidpm.frp.model.Pairorg.rapidpm.frp.model.Tripleorg.rapidpm.frp.model.Quadorg.rapidpm.frp.model.Quintorg.rapidpm.frp.model.Sextorg.rapidpm.frp.model.SeptThis now brings your total coverage to
58.5%.In addition, I found a bug with the
toStringmethod oforg.rapidpm.frp.model.Sext, which has been fixed. This allows the test written for this method, to pass.Hopefully, these tests will help you detect any regressions caused by future code changes. We would be grateful for any feedback you have regarding the quality of these tests.