Use gopkg.in/Masterminds/squirrel.v1 instead of github.com/Masterminds/squirrel #280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…s/squirrel Signed-off-by: Florent AIDE <florent.aide@gmail.com>
Contributor
| Which go version are you using? According to squirrel's README:
PR seems harmless and more explicit tho, so I'm inclined to merge it. Just want to know which is the root cause of the problem. |
Author
| I am using go 1.10.3 Le 1 juil. 2018 2:30 PM, "Roberto Santalla" <notifications@github.com> a écrit : … Which go version are you using? According to squirrel's README: NOTE: as of Go 1.6, go get correctly clones the Github default branch (which is v1 in this repo). import "github.com/Masterminds/squirrel" PR seems harmless and more explicit tho, so I'm inclined to merge it. Just want to know which is the root cause of the problem. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#280 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAeL8aHbU1ttiPeSEw60-0czCNjJT8gdks5uCMDfgaJpZM4U7bGM> . |
| I'm using |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
because the github version pulls from master and is not in synch with what kallax uses from squirrel.
See #279 for more reference