Skip to content

[Suggestion] for issue #988 need to initiate discussion for further changes #989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[Suggestion] for issue #988 need to initiate discussion for further changes #989

wants to merge 2 commits into from

Conversation

@gauravpolekar
Copy link

@gauravpolekar gauravpolekar commented Jun 19, 2021 •
edited
Loading

  • You have read the Spring Data contribution guidelines.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).
@gauravpolekar
Temporary fix for proper one to one mapping
234305c 
Simple ***suggestion fix for one to one mapping, As per most common schemas. Complete solution needs to be discuss and corrected.,
@gauravpolekar
Update SqlGeneratorUnitTests.java
26ff75c
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jun 19, 2021
@schauder
Copy link
Contributor

We will not implement #988. See there for more information why.
@schauder schauder closed this Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: waiting-for-triage An issue we've not yet triaged

3 participants

@gauravpolekar @schauder @spring-projects-issues