DATAJDBC-115 - Adapt to changes in SD Commons API. #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
mp911de added a commit that referenced this pull request Feb 21, 2022
DatabaseClient now no longer exposes the exchange() method but rather provides map(…) and then(…) methods. Calling map(…) extracts values from tabular results by propagating the mapping function to Result.map(…). then() allows statement execution without returning the result propagating only completion and error signals. Original pull request: #33.
mp911de pushed a commit that referenced this pull request Feb 21, 2022
Formatting, JavaDoc, issue comments on `@Test` annotations. Removed some dead code. Original pull request: #33.
mp911de added a commit that referenced this pull request Feb 21, 2022
Remove unused code from AbstractDatabaseClientIntegrationTests. Use literal null instead of code null for consistency. Original pull request: #33.
mp911de added a commit that referenced this pull request Feb 21, 2022
Move retrieval methods from FetchSpec into RowsFetchSpec and UpdatedRowsFetchSpec. map(…) now returns RowsFetchSpec to not expose updated rows count as mapped results are consumed as objects. Original pull request: #33.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.