DATAJDBC-102 - Determine the EntityInstantiator to be used dynamically. #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
mp911de requested changes May 15, 2018
Member
mp911de left a comment
mp911de left a comment There was a problem hiding this comment.
I left a comment about the direction of dependencies.
| @Getter private SimpleTypeHolder simpleTypeHolder; | ||
| private GenericConversionService conversions = getDefaultConversionService(); | ||
| @Setter | ||
| private EntityInstantiators instantiators = new EntityInstantiators(); |
Member
There was a problem hiding this comment.
EntityInstantiators is a type from the conversion subsystem, it should rather be held in a type residing in the .core.conversion package. How about moving this field to DefaultDataAccessStrategy?
schauder force-pushed the issue/DATAJDBC-102 branch from 64770d3 to 5a0c5c2 Compare 
Execute Hsql specific integration test only with Hsql.
Replaced the direct use of EntityInstantiator with EntityInstantiators. Moved it into the MappingContext because instantiation is part of the mapping process.
…faultDataAccessStrategy and EntityRowMapper.
schauder force-pushed the issue/DATAJDBC-102 branch from 5a0c5c2 to 64ce22c Compare 
Contributor Author
| @mp911de made the requested changes and rebased to the current master. |
mp911de pushed a commit that referenced this pull request Jun 4, 2018
Replaced the direct use of EntityInstantiator with EntityInstantiators. Moved it into the MappingContext because instantiation is part of the mapping process. Original pull request: #68.
mp911de pushed a commit that referenced this pull request Jun 4, 2018
Execute Hsql specific integration test only with Hsql. Original pull request: #68.
mp911de added a commit that referenced this pull request Jun 4, 2018
Pull entity instantiation into a single method. Original pull request: #68.
Member
| That's merged and polished now. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Replaced the direct use of EntityInstantiator with EntityInstantiators.
Moved it into the MappingContext because instantiation is part of the mapping process.