Skip to content

Conversation

@uaihebert
Copy link
Contributor

Until now, only classes without injection had support. This commit will add two new params at the @Query annotation.

In these new params will be possible to add Spring Beans allowing the user to use Spring Beans.

@uaihebert
Copy link
Contributor Author

One comment, I had to isolate the configurations of the beans in a separate class—the injection of other tests broken due to the rowMapper service not being available.

@uaihebert uaihebert changed the title Allow injection of "row mapper," and "result set extractor" beans. issue/DATAJDBC-430 - Allow injection of "row mapper," and "result set extractor" beans. Aug 27, 2020
@schauder
Copy link
Contributor

schauder commented Oct 5, 2020

Thanks for tackling this issue.

I'm afraid the comment on the issue by myself:

We should introduce new annotation attributes rowMapperBean and resultSetExtractorBean for this.

wasn't precise enough.

These attributes should be of type String and denote the bean name of the bean to be used.

If you could adjust the PR according to that, I'd be happy to merge it.

Until now, only classes without injection had support. This commit will add two new params at the `@Query` annotation. In these new params will be possible to add Spring Beans allowing the user to use Spring Beans.
@uaihebert
Copy link
Contributor Author

I just finished the update. I will prepare a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants