DATAJDBC-341 - Map NULL values in EntityRowMapper for columns not being fetched in the query (fixed tests) #201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
mp911de requested changes Mar 30, 2020
| * | ||
| * @author Jens Schauder | ||
| */ | ||
| class ResultSetWrapper { |
Member
There was a problem hiding this comment.
Typically, we use a PropertyValueProvider to wrap the actual source.
| for (int i = 1; i <= columnCount; i++) { | ||
| | ||
| String label = metaData.getColumnLabel(i).toLowerCase(); | ||
| Integer previous = index.put(label, i); |
Member
There was a problem hiding this comment.
As per JDBC spec: Encountering a column label more than once, then the first label is used. I'd suggest a case-insensitive Set<String> (see LinkedCaseInsensitiveMap) to check for column names.
…ng fetched in the query. Original pull request: #170.
Turns out this was a little more involved than expected. This modifies the implementation to not use exceptions for flow control. Properties that get set via setter, wither or field access get not invoked for missing columns. When properties get referenced in constructors a missing column results in an exception. As a side effect we now access the `ResultSet` by index. Depending on how the driver is implemented this might improve the performance a little.
ResultSetWrapper now uses the first column when multiple columns with the same effective name exist. It employs a LinkedCaseInsensitiveMap for storing the mapping columnnames to indexes.
Introduced two differen PropertyValueProvider implementations in order to encapsulate the two variants how ResultSets get accessed.
schauder force-pushed the pr/datajdbc-341 branch from 19c4271 to fa98642 Compare 
mp911de pushed a commit that referenced this pull request Mar 31, 2020
Turns out this was a little more involved than expected. This modifies the implementation to not use exceptions for flow control. Properties that get set via setter, wither or field access get not invoked for missing columns. When properties get referenced in constructors a missing column results in an exception. As a side effect we now access the `ResultSet` by index. Depending on how the driver is implemented this might improve the performance a little. Original pull request: #201.
mp911de added a commit that referenced this pull request Mar 31, 2020
Remove SpecialColumnValue in favor of JdbcPropertyValueProvider.hasProperty(…). Rename ResultSetWrapper to ResultSetAccessor. Replace ResultSetAccessor usage in JdbcConverter with ResultSet to avoid visibility issues. Original pull request: #201.
Member
| That's merged and polished now. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
While reviewing #170 I realised various more cases and ended up doing more changes than the original PR. Therefore I'd like to get another review of the changes.
Issue: https://jira.spring.io/browse/DATAJDBC-341