Skip to content

Conversation

@mipo256
Copy link
Contributor

@mipo256 mipo256 commented Jul 30, 2024

This is the migration from org.springframework.r2dbc.core.Parameter, which is considered to be deprecated, to io.r2dbc.spi.Parameter.

P.S: Still some work in progress, regarding tests.

@mipo256 mipo256 marked this pull request as draft July 30, 2024 20:02
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jul 30, 2024
@mp911de
Copy link
Member

mp911de commented Aug 5, 2024

Thanks for the PR. While it's a bit early in the process, we want to migrate off the deprecated class. However, this change is scheduled for the next major release.

@mp911de mp911de added type: enhancement A general enhancement has: breaking-change An issue that is associated with a breaking change. and removed status: waiting-for-triage An issue we've not yet triaged labels Aug 5, 2024
@mipo256
Copy link
Contributor Author

mipo256 commented Aug 5, 2024

Sure, I understand.
I'll polish it in upcoming days. I can also include migration off the other deprecated classes in the same PR. Is that fine?

@mp911de
Copy link
Member

mp911de commented Aug 6, 2024

For the time being, we will have to stick to our own deprecations such as ReactiveDataAccessStrategy. We could indeed un-deprecate these classes as there is no replacement available yet but that would send the wrong signal. The entire data access part for R2DBC requires a revision that can only be done in a bigger change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

has: breaking-change An issue that is associated with a breaking change. type: enhancement A general enhancement

3 participants