Skip to content

Issue/1828 aggregate ref with convertable #1829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 10 commits into from
Closed

Issue/1828 aggregate ref with convertable #1829

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
6e60ab4
1828-aggregate-ref-with-convertable - Prepare branch
schauder Jul 4, 2024
9d4d272
probably reproduced the issue in test
schauder Jul 4, 2024
5423856
added unit test for the problem
schauder Jul 5, 2024
2f18a24
fix the type holder, still doesn't resolve the issue
schauder Jul 5, 2024
462380a
fix the integration test
schauder Jul 5, 2024
1c15a9a
Polishing
schauder Jul 4, 2024
e7a38b6
Polishing
schauder Jul 4, 2024
7cf3bc9
polishing
schauder Jul 4, 2024
88a7e12
Polishing.
schauder Jul 5, 2024
531171e
polishing
schauder Nov 6, 2024
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix the integration test
  • Loading branch information
@schauder
schauder committed Dec 16, 2024
commit 462380aac87ae25fa07100ed69ca24048c0f95fd
2 changes: 1 addition & 1 deletion .../java/org/springframework/data/relational/core/conversion/MappingRelationalConverter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -690,7 +690,7 @@ public Object writeValue(@Nullable Object value, TypeInformation<?> type) {
: getConversions().getCustomWriteTarget(type.getType());

if (customWriteTarget.isPresent()) {
return getConversionService().convert(value, customWriteTarget.get());
return getPotentiallyConvertedSimpleWrite(getConversionService().convert(value, customWriteTarget.get()));
}

if (TypeInformation.OBJECT != type) {
Expand Down