DATAJDBC-329 - Replacing JdbcConfiguration. #116
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Reverting breaking changes to JdbcConfiguration. Deprecating JdbcConfiguration in favor of AbstractJdbcConfiguration. Cleaning up the API to separate it from spring-data-relational and therefore R2DBC.
mp911de reviewed Feb 6, 2019
| @@ -0,0 +1,109 @@ | |||
| /* | |||
| * Copyright 2017-2019 the original author or authors. | |||
Contributor Author
There was a problem hiding this comment.
I was thinking about that. Since it is actually a copy of the JdbcConfiguration I thought keeping the inception date would be appropriate.
What do you think?
mp911de reviewed Feb 6, 2019
| * @return must not be {@literal null}. | ||
| */ | ||
| @Bean | ||
| public JdbcConverter relationalConverter(RelationalMappingContext mappingContext) { |
Member
There was a problem hiding this comment.
How about naming this bean jdbcConverter to avoid clashes with other relational converters?
mp911de requested changes Feb 6, 2019
Member
mp911de left a comment
mp911de left a comment There was a problem hiding this comment.
I left a few comments. Feel free to merge this one afterwards.
schauder added a commit that referenced this pull request Feb 6, 2019
Reverting breaking changes to JdbcConfiguration. Deprecating JdbcConfiguration in favor of AbstractJdbcConfiguration. Cleaning up the API to separate it from spring-data-relational and therefore R2DBC. Original pull request: #116.
schauder added a commit that referenced this pull request Feb 6, 2019
Applied review feedback. Original pull request: #116.
Contributor Author
| Thanks for the help @mp911de |
schauder added a commit that referenced this pull request Feb 11, 2022
mp911de pushed a commit that referenced this pull request Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Reverting breaking changes to JdbcConfiguration.
Deprecating JdbcConfiguration in favor of AbstractJdbcConfiguration.
Cleaning up the API to separate it from spring-data-relational and therefore R2DBC.