Reimplemented dependency tests using ArchUnit. #1107
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Moved RelationalAuditingCallback and JdbcArrayColumns to remove dependency cycle. Closes #1058
gregturn reviewed Dec 6, 2021
| <dependency> | ||
| <groupId>com.tngtech.archunit</groupId> | ||
| <artifactId>archunit</artifactId> | ||
| <version>0.22.0</version> |
There was a problem hiding this comment.
Do you prefer keeping all the versions as property settings at the top?
| void acrossModules() { | ||
| | ||
| JavaClasses importedClasses = new ClassFileImporter().withImportOption(ImportOption.Predefined.DO_NOT_INCLUDE_TESTS) | ||
| .importPackages( // |
There was a problem hiding this comment.
Make this consistent with the previous test.
| return new DescribedPredicate<>("Spring Data Classes") { | ||
| @Override | ||
| public boolean apply(JavaClass input) { | ||
| |
There was a problem hiding this comment.
Do you need the blank line if there is only one line in the method?
| void acrossModules() { | ||
| | ||
| JavaClasses importedClasses = new ClassFileImporter().withImportOption(ImportOption.Predefined.DO_NOT_INCLUDE_TESTS) | ||
| .importPackages( // |
| return new DescribedPredicate<>("Spring Data Classes") { | ||
| @Override | ||
| public boolean apply(JavaClass input) { | ||
| |
| Thanks for the review. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Moved RelationalAuditingCallback and JdbcArrayColumns to remove dependency cycle.
Closes #1058