#363 - Derived Query support count projection #360
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
m1ngyuan reviewed May 5, 2020
| .collect(Collectors.toList()); | ||
| } else if (tree.isCountProjection()) { | ||
| | ||
| SqlIdentifier idColumn = entityMetadata.getTableEntity().getRequiredIdProperty().getColumnName(); |
There was a problem hiding this comment.
remove duplicated thanks for commenting
mhyeon-lee force-pushed the datajdbc534-derived-query-support-count-projection branch from 0cca10e to 1cc1674 Compare 
mp911de changed the title 
schauder pushed a commit that referenced this pull request May 11, 2020
Original pull request: #360.
schauder added a commit that referenced this pull request May 11, 2020
Added an integration test and tweaked the conversions to make it succeed. The converter now does not rely on the driver to do the conversion anymore. Original pull request: #360.
| Thanks, that is merged and polished. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
same issue:
https://jira.spring.io/browse/DATAJDBC-534
spring-projects/spring-data-relational#215 (comment)