DATACMNS-1210 - Fix concurrency issue in BasicPersitentEntity. #259
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Make sure to use concurrent collection implementations for properties holding mutable state. Especially the ones making use of
computeIfAbsent()
.Usage of
ConcurrentReferenceHashMap
allows us to move on without additional changes as it allows to storenull
values, whereasConcurrentHashMap
would require us to store explicitNullValue
placeholders for such cases, potentially causing trouble in downstream store specific projects.JMH Benchmarks (for the mapping layer in Spring Data MongoDB) comparing
ConcurrentReferenceHashMap
andConcurrentHashMap
did not show any significant difference between the two.