Fix float issue with object space dump #146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
mcmire reviewed Apr 7, 2022
.tool-versions Outdated
| @@ -1 +1 @@ | |||
| ruby 2.5.9 | |||
| ruby 2.7.1 | |||
Collaborator
There was a problem hiding this comment.
Thanks for the change! Mind putting this in another PR? This seems like something someone may want to track down later and I don't want it to get lost in this one.
Collaborator
There was a problem hiding this comment.
Actually, take that back — since we still support Ruby 2.5 as the minimum tested version, we probably want to leave this alone :)
Contributor Author
There was a problem hiding this comment.
I will fix this error in the test suite
NoMethodError: undefined method `try' for #<Hash> Did you mean? pry Contributor Author
There was a problem hiding this comment.
The remainder that are failing are probably due to an issue with ruby version + minitest version issues, I pushed up #148 to try and fix the issue
This reverts commit a663893.
Contributor Author
| I merged |
Collaborator
| Done and merged! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
A fix for #144 and align
.tool-versionwith.ruby-version