Skip to content

Conversation

@aried3r
Copy link
Contributor

@aried3r aried3r commented May 21, 2021

Adds testing with Rails 6.1. With rspec <3.10 I had over 263 test failures so I excluded it from the matrix and Appraisal.

@mcmire
Copy link
Collaborator

mcmire commented May 21, 2021

Thanks for doing this. Is RSpec < 3.10 not compatible with Rails 6.1? If it's intended to be compatible, is that something you think should be addressed? Or did you just want to make sure that something around Rails 6.1 integration was added to the test suite?

@aried3r
Copy link
Contributor Author

aried3r commented May 26, 2021

Hey!

I am not a 100% sure how the rspec meta-gem relates to it. However it appears to me that official Rails 6.1 support hit rspec-rails in 5.0.0, with some fixes being in previous versions.

In turn, this version seems to request rspec-* of 3.10 or above.

I have no data on this, but my assumption is that users of Rails 6.1 which requires Ruby 2.5 have a reasonably up-to-date setup and will be using the rspec-rails version that has official support for it.

Do you think this is a reasonable approach for this gem?

Edit: I forgot to answer your questions directly.

Is RSpec < 3.10 not compatible with Rails 6.1? If it's intended to be compatible, is that something you think should be addressed?

I don't think it should be addressed, see explanation above.

Or did you just want to make sure that something around Rails 6.1 integration was added to the test suite?

Yes 😅

@aried3r
Copy link
Contributor Author

aried3r commented Oct 1, 2021

Hey @mcmire! If you're okay with the PR as it is, I'd perhaps also add Rails 7 alpha if you're interested.

@mcmire
Copy link
Collaborator

mcmire commented Feb 10, 2023

Hey @aried3r! So sorry for not getting to this PR until now. I've been working with @petergoldstein on some updates to the CI matrix as well and he incorporated your PR into his. I made sure you were credited on the commit. Hope that's okay!

@aried3r
Copy link
Contributor Author

aried3r commented Feb 10, 2023

Absolutely, thank you!

@mcmire mcmire closed this Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants