Skip to content

Conversation

@guiferrpereira
Copy link
Contributor

Corrects issue #97

@mcmire
Copy link
Collaborator

mcmire commented Dec 11, 2020

Hi @guiferrpereira. Thanks for this PR. Is it possible for you to add a new context and test to this file https://github.com/mcmire/super_diff/blob/master/spec/integration/rspec/match_array_matcher_spec.rb which makes sure that this isn't an issue going forward?

@guiferrpereira guiferrpereira force-pushed the 97_fix_match_array_string branch from 8175d26 to 9726c3e Compare December 11, 2020 19:15
@guiferrpereira
Copy link
Contributor Author

@mcmire specs added

@mcmire
Copy link
Collaborator

mcmire commented Dec 18, 2020

Okay! Thanks so much!

@mcmire mcmire merged commit 034c902 into splitwise:master Dec 18, 2020
@guiferrpereira
Copy link
Contributor Author

@mcmire can you create the 0.5.3 release please? thanks

@mcmire
Copy link
Collaborator

mcmire commented Dec 21, 2020

@guiferrpereira Yes, thanks for the reminder. 0.5.3 is now available with this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants