Skip to content

Use named routes instead of url helper with paths #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Use named routes instead of url helper with paths #75

wants to merge 5 commits into from

Conversation

@Michael-Stokoe
Copy link

@Michael-Stokoe Michael-Stokoe commented Dec 18, 2019 •
edited
Loading

Changes in this PR:

  • Changed instances of url() . '/some/path' to route('named.route') instead. (Allows for us to change the routes of the package incase there are conflicts with pre-existing application routes).
  • Moved routes to dedicated file, to clean up the service provider
  • Moved namespaced resources to /src/ directory.
  • Moved resources to root directory.
  • Moved migrations to root directory.
@Michael-Stokoe
Copy link
Author

Fixes this:

#74
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant

@Michael-Stokoe