Add support for the PhpStorm Mac scheme #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
added 3 commits February 28, 2017 12:04
Reduced comment
Removed escapes
Removed first capturing group
| Added that. Thanks for your contribution! |
harcod commented Feb 28, 2017
| | ||
| arg=${1} | ||
| pattern=".*file(:\/\/|\=)(.*)&line=(.*)" | ||
| pattern=".*file(?::\/\/|\=)(.*)&line=(.*)" |
There was a problem hiding this comment.
I tested the merged code and unfortunately it failed.
Non-capturing groups are not supported by sed
That regex syntax is only supported in PCRE (not BRE or ERE which sed supports)
There was a problem hiding this comment.
Reverted that back to what you suggested first.
Thanks again!
There was a problem hiding this comment.
I tested Release 1.2.1 and it works perfectly! Thanks for making the changes to the master.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
PhpStorm 8 (Mac) provided native support for the "phpstorm:" protocol. However, they implemented a different format for the the URL.
PhpStorm Mac uses:
phpstorm://open?file=@file&line=@lineThis handler uses
phpstorm://open?url=file://@file&line=@linesymfony/symfony#21712 is going to change the default format to be the Macintosh format.
This pull request contains the necessary modifications to support both formats simultaneously. This would standardize the system so that you would not need two different configurations if you are working on different platforms (i.e. Linux vs Mac)