linux-musl-s390x: Add __psw_t/fprefset_t/*context_t #4726
+25 −0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Gelbpunkt suggested changes Sep 26, 2025
| | ||
| pub struct fpregset_t { | ||
| pub fpc: u32, | ||
| __pad: u32, |
There was a problem hiding this comment.
I don't see this padding in musl sources?
There was a problem hiding this comment.
It isn't explicit, but the compiler ends up adding it anyway. Many other structs in libc are defined with explicit padding. I don't know the official policy (either way it should ideally be enforced in CI)
There was a problem hiding this comment.
removed for now.
There was a problem hiding this comment.
As far as I can tell, padding fields are only used when they are also defined in the libc headers
neuschaefer force-pushed the s390x-mctx branch from a44f9fd to 2d668ab Compare Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
Define signal-related structs according to musl-libc. These structs are already mentioned in libc-test/semver/linux-s390x.txt, so it makes sense to define the for musl, not just for glibc.
Sources
https://elixir.bootlin.com/musl/v1.2.5/source/arch/s390x/bits/signal.h
Checklist
Relevant tests inno changelibc-test/semverhave been updated*LASTor*MAXareincluded (see #3131)
cd libc-test && cargo test --target mytarget);especially relevant for platforms that may not be checked in CI