Skip to content

Conversation

@highjeans
Copy link

@highjeans highjeans commented Mar 19, 2025

Description

This PR changes the callback function type to be unsafe rather than safe in (i believe) all functions that need a callback function, as per the discussion in #2198.

Closes #2198

Sources

As no APIs were changes (other than making the callback type unsafe), and safe vs unsafe functions are not documented in the linux documentation/header files, there are no sources.

Checklist

  • Relevant tests in libc-test/semver have been updated
  • No placeholder or unstable values like *LAST or *MAX are
    included (see #3131)
  • Tested locally (cd libc-test && cargo test --target mytarget);
    especially relevant for platforms that may not be checked in CI
@rustbot
Copy link
Collaborator

rustbot commented Mar 19, 2025

r? @tgross35

rustbot has assigned @tgross35.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot
Copy link
Collaborator

rustbot commented Mar 19, 2025

Some changes occurred in the Android module

cc @maurer

@tgross35
Copy link
Contributor

These look good to me, but there seem to be a few more cases. Would you mind getting those as well? https://github.com/search?q=repo%3Arust-lang%2Flibc%20%2F%3A.*fn%5C(%2F&type=code for a rough search, e.g. the aix module, solaris, espidf, and a few others.

We can't backport this since it is breaking unfortunately, but it will be great to have for 1.0:

@rustbot label +stable-declined

@rustbot rustbot added the stable-declined This change is breaking, difficult to backport, low priority, or otherwise not relevant for 0.2 label Mar 22, 2025
@tgross35
Copy link
Contributor

tgross35 commented Apr 2, 2025

@rustbot author for the request above

@rustbot
Copy link
Collaborator

rustbot commented Apr 2, 2025

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@tgross35
Copy link
Contributor

@highjeans gentle ping, would you be able to take a look at the above suggestion?

@highjeans
Copy link
Author

@tgross35 Sorry for the late response, I was busy with a large assignment for university. I am outside today, but when I get home I will take a look and update the PR.

@tgross35
Copy link
Contributor

tgross35 commented Sep 1, 2025

@highjeans another gentle ping on this one :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

O-android O-linux O-unix O-windows S-waiting-on-author stable-declined This change is breaking, difficult to backport, low priority, or otherwise not relevant for 0.2

3 participants