Skip to content

Conversation

@petyaslavova
Copy link
Collaborator

Pull Request check-list

Please make sure to review and check all of these items:

  • Do tests and lints pass with this change?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Please provide a description of the change here.

@petyaslavova petyaslavova requested a review from Copilot October 24, 2025 09:22
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for hybrid search functionality to the Redis search client, enabling combined text and vector similarity searches. The implementation introduces new query types, result parsers, and comprehensive test coverage.

Key changes:

  • New hybrid query classes for combining text search and vector similarity operations
  • Hybrid search command execution and result parsing
  • Post-processing configuration for filtering, sorting, and aggregating results

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
tests/test_search.py Comprehensive test suite covering hybrid search functionality including various query types, filters, and post-processing options
redis/connection.py Minor whitespace cleanup (removed blank line)
redis/commands/search/hybrid_query.py New file implementing hybrid query classes and post-processing configuration
redis/commands/search/commands.py Added hybrid_search method and result parsing logic
redis/commands/search/init.py Registered hybrid search command parser

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@petyaslavova petyaslavova added the feature New feature label Oct 24, 2025
@petyaslavova petyaslavova force-pushed the ps_add_hybrid_search branch 3 times, most recently from 1e8345a to 3b3b4f5 Compare October 29, 2025 08:13
@petyaslavova petyaslavova marked this pull request as draft October 29, 2025 08:17
@petyaslavova petyaslavova changed the title Adding support for hybrid search. Adding support for HYBRID search. Nov 3, 2025
@petyaslavova petyaslavova requested a review from Copilot November 3, 2025 12:39
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 6 out of 7 changed files in this pull request and generated 8 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@petyaslavova petyaslavova force-pushed the ps_add_hybrid_search branch 2 times, most recently from 0ea7eec to fc7c324 Compare November 4, 2025 10:55
@petyaslavova petyaslavova marked this pull request as ready for review November 4, 2025 10:58
@petyaslavova petyaslavova requested a review from Copilot November 4, 2025 11:36
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 5 out of 6 changed files in this pull request and generated 4 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature

2 participants