-   Notifications  
You must be signed in to change notification settings  - Fork 2.6k
 
Adding support for HYBRID search. #3813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for hybrid search functionality to the Redis search client, enabling combined text and vector similarity searches. The implementation introduces new query types, result parsers, and comprehensive test coverage.
Key changes:
- New hybrid query classes for combining text search and vector similarity operations
 - Hybrid search command execution and result parsing
 - Post-processing configuration for filtering, sorting, and aggregating results
 
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description | 
|---|---|
| tests/test_search.py | Comprehensive test suite covering hybrid search functionality including various query types, filters, and post-processing options | 
| redis/connection.py | Minor whitespace cleanup (removed blank line) | 
| redis/commands/search/hybrid_query.py | New file implementing hybrid query classes and post-processing configuration | 
| redis/commands/search/commands.py | Added hybrid_search method and result parsing logic | 
| redis/commands/search/init.py | Registered hybrid search command parser | 
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
1e8345a to 3b3b4f5   Compare   3b3b4f5 to 551315b   Compare   There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 6 out of 7 changed files in this pull request and generated 8 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
0ea7eec to fc7c324   Compare   There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 5 out of 6 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ce28c55 to ae531b0   Compare   
Pull Request check-list
Please make sure to review and check all of these items:
NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
Please provide a description of the change here.