Skip to content

Conversation

ManelCoutinhoSensei
Copy link
Contributor

Pull Request check-list

Please make sure to review and check all of these items:

  • Do tests and lints pass with this change?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Fixes #3560. It should be reviewed after merging #3596

@petyaslavova
Copy link
Collaborator

Hi @ManelCoutinhoSensei, thank you for your contribution! We’ll review your change soon(after PR #3596 :) ).

@ManelCoutinhoSensei
Copy link
Contributor Author

It's been 2 months... do you have any updates @petyaslavova ?

Copy link
Collaborator

@petyaslavova petyaslavova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ManelCoutinhoSensei,
Apologies for the late response. I’ve reviewed the code and added a few comments.

@petyaslavova
Copy link
Collaborator

@ManelCoutinhoSensei, please check why tests are failing.

@ManelCoutinhoSensei ManelCoutinhoSensei force-pushed the sentinel-master-detection branch 4 times, most recently from ed67cd1 to 1492c3a Compare July 17, 2025 09:42
@ManelCoutinhoSensei
Copy link
Contributor Author

Hi @petyaslavova , besides the one workflow that fails due to having the same name as another, all tests seem to pass here
I've noticed that some of them are flaky but I think that it is not due to my changes (since my main branch synced with this repo's master also fails sometimes)

@ManelCoutinhoSensei ManelCoutinhoSensei force-pushed the sentinel-master-detection branch from 1492c3a to 7af0b7f Compare July 17, 2025 15:54
@ManelCoutinhoSensei
Copy link
Contributor Author

Thank you so much, @petyaslavova. Once this is closed, I'll update the other PR accordingly

@petyaslavova petyaslavova merged commit 31399ed into redis:master Jul 23, 2025
67 of 68 checks passed
@ManelCoutinhoSensei ManelCoutinhoSensei deleted the sentinel-master-detection branch July 25, 2025 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2 participants