Allows asyncio cluster mode connections to wait for free connection when at max.

[cavemanpi]

Pull Request check-list

Please make sure to review and check all of these items:

• Do tests and lints pass with this change?
• Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
• Is the new or changed code fully tested?
• Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
• Is there an example added to the examples folder (if applicable)?
• Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

This change adds a flag to the cluster client which is propagated down to the cluster node object called 'wait_for_connections'. This helps in highly distributed high throughput environments where redis connections need to be capped to avoid running into connection limits, but also we want the request to make it through eventually in the event of some sort of stampede.

[vladvildanov]

@cavemanpi This functionality is already covered by BlockingConnectionPool, you should use RedisCluster with provided configuration connection_pool_class=BlockingConnectionPool

https://github.com/redis/redis-py/blob/master/redis/connection.py#L1306

[cavemanpi]

@cavemanpi This functionality is already covered by BlockingConnectionPool, you should use RedisCluster with provided configuration connection_pool_class=BlockingConnectionPool

https://github.com/redis/redis-py/blob/master/redis/connection.py#L1306

Please take a look again. What you say is valid for the synchronous client, but I don't think it's true for the asyncio client.

[cavemanpi]

@vladvildanov I updated the title to make it clearer this is in reference to the asyncio client.

[vladvildanov]

@cavemanpi Thanks for clarification! We already have a PR that aims to cover the same functionality, feel free to join as well!

#3321

[cavemanpi]

@vladvildanov, thanks for pointing me at that other PR; I appreciate it, but I find myself a little confused as I think that is trying to solve a different, but related problem.

redis-py/redis/asyncio/cluster.py

Line 390 in 2fb40c1

self.nodes_manager = NodesManager(

From what I can see the asyncio RedisCluster class makes use of a class called NodesManager to track cluster nodes and route commands to the correct nodes. There is not a constructor parameter to override what is used for a NodesManager class replacement. This NodesManager class has mappings to ClusterNode objects which conceptually act like both the representation of a node as well as a connection pool. There also does not look to be a public constructor parameter to override the connection pooling behavior.

Is the proper fix here to actually decouple the concept of the cluster node from its connection pool and make the connection pool class configurable like most of the rest of the clients?

[vladvildanov]

@cavemanpi For alignment with sync API we have to have connection_pool_class argument in constructor, so this way it would be possible to set a type for connection pool. Use sync API as an example

redis-py/redis/cluster.py

Line 1349 in 2fb40c1

connection_pool_class=ConnectionPool,

[github-actions]

This pull request has been automatically marked as stale due to inactivity.
It will be closed in 30 days if no further activity occurs.

[github-actions]

This pull request has been automatically closed due to inactivity.
If you would like to continue this work, please reopen the PR or create a new one.