Skip to content

Conversation

@ashwani99
Copy link
Contributor

@ashwani99 ashwani99 commented Dec 14, 2021

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

@codecov-commenter
Copy link

codecov-commenter commented Dec 14, 2021

Codecov Report

Merging #1790 (459cab5) into master (f82ab33) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@ ## master #1790 +/- ## ======================================= Coverage 94.22% 94.22% ======================================= Files 74 74 Lines 15681 15681 ======================================= Hits 14776 14776 Misses 905 905 

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f82ab33...459cab5. Read the comment docs.

@chayim
Copy link
Contributor

chayim commented Dec 15, 2021

@ashwani99 awesome - this reproduces #1784 perfectly. I'll see what I can do to fix that.

@WisdomPill
Copy link
Contributor

My two cents, I think this should be done for every version of python supported

@chayim
Copy link
Contributor

chayim commented Dec 15, 2021

@WisdomPill Now that we have this, I think it's fair. @ashwani99 mind trying to yank the python-version and add it to your matrix, in addition to updating the name for this test to reflect the matrix? Then, I think we have something amazing, test-wise. Also, if you prefer I can add this change directly to your PR. I'd never want to step on your toes.

@ashwani99
Copy link
Contributor Author

ashwani99 commented Dec 15, 2021

@chayim sure, I will add the support for all python versions 3.6+

@chayim
Copy link
Contributor

chayim commented Dec 15, 2021

@ashwani99 For what it's worth, this was alerady useful. I used it to validate #1792 our collaboration on the resulting change from #1784

@chayim
Copy link
Contributor

chayim commented Dec 15, 2021

Thanks @ashwani99! It has been such a pleasure. Merging as discussed in #1784

@chayim chayim merged commit 6c1e215 into redis:master Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Maintenance (CI, Releases, etc)

4 participants