Skip to content

Conversation

@Andrew-Chen-Wang
Copy link
Contributor

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

In #1506, the Redis class method's docs was not properly added

Copy link
Contributor

@chayim chayim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Andrew-Chen-Wang Thanks again! I love the improvements to our documentation!

But - while we're here, would you mind terribly remove the double space after (bind)?

@chayim chayim merged commit 55ea5fb into redis:master Oct 18, 2021
@Andrew-Chen-Wang Andrew-Chen-Wang deleted the patch-1 branch October 20, 2021 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants