[RayJob] Lift cluster status while initializing #4191
+80 −16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Signed-off-by: Spencer Peterson <spencerjp@google.com>
spencer-p requested review from MortalHappiness, andrewsykim, kevin85421 and rueian as code owners 
Contributor Author
| I also noticed that an updated ray cluster status is silently discarded unless the job status has changed, which may further obscure runtime issues after job submission. IMO this is another opportunity for improvement and would be happy to contribute that as well. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
When deploying a RayJob, the RayCluster status may have valuable info about runtime failures before the cluster becomes ready. In such cases, the RayJob remains Initializing and never updates its status.
This is a common failure mode and may confuse new users that don't realize they need to inspect the ray cluster -- but we should use the existing ray cluster status subfield to reflect this information.
Related issue number
n/a
Checks