merge with http-random-access #16
Conversation
| Do you see any advantages to one or the other (yours seems more complete)? |
| For me the main thing that the current implementation misses is the ability to use relative file paths from a base path. Without this its not possible to use as a drop in replacement for dat storage. The other advantage of this implementation would be that it should be usable in the browser too - as its using axios rather than node by default. Other than those our implementations are pretty similar. |
| I originally wrote my implementation for this - https://github.com/e-e-e/dat-http-proxy. |
| Want to just merge the repos replacing my older implementation with yours and keep the more consistent random-access-http name? |
| That was my original thought - but actually i ended up grabbing details from yours for this branch too. All the checks on content-length are from your implementation. |
| I feel like this branch is the combination of both of our work - is there anything you see missing? |
bcomnes left a comment
bcomnes left a comment There was a problem hiding this comment.
LGTM added you as an npm publisher so you can publish freely.
| I'll let you merge when ready |
| Awesome @bcomnes thanks. I will do a major version bump and publish shortly. |
@bcomnes this is a merge of our two http interfaces - do you want to have a look over and let me know what you think.
This will close these issues:
#15
#11