[Draft] Add types (POC) #243
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…is not subclass of `Dict`)
ramnes reviewed Oct 28, 2024
| return body | ||
| | ||
| @abstractclassmethod | ||
| @abstractmethod |
ramnes reviewed Oct 28, 2024
| self, | ||
| path: str, | ||
| method: str, | ||
| cast_to: Type[ResponseType], |
There was a problem hiding this comment.
can we avoid to add this new cast_to argument?
| I'll go ahead and close this for now. Feel free to open a new PR if you still want to work on this! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Add output (and maybe input) types to response (requests).
For details, please see: #199
How to achive this:
ClientandAsyncClientoverloaddecorator to add two overloads (one for sync and another one async) of each request method