This repository was archived by the owner on Jan 2, 2024. It is now read-only.
Add missing .form-label classes in BS5 forms #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| @pascalbaljet please merge this. bs4 to bs5 has this minor change to the form labels |
| @maciag-m isn't it better to add this class as default in the label component? @pascalbaljet is this repo active? need reviewer or some help? |
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
According to BS5 docs, form labels should contain .form-label class to be displayed correctly. Without it, the space between label and field is too small.
Before:
After:
