Skip to content
This repository was archived by the owner on Jan 2, 2024. It is now read-only.

Conversation

DionPotkamp
Copy link
Contributor

@DionPotkamp DionPotkamp commented Jun 15, 2021

Bootstrap 5 is out of beta and has some real improvements for forms.

Hereby the bootstrap 5 version of laravel-form-components including floating labels.

image

With bootstrap 5 form-group has been removed. It's still a component because it can be used for inline radio's and check boxes with validation.

prepend and append are also removed. This is replaced by input-group and can contain basically anything (just text, but also buttons and radio's).

Read more here: Bootstrap 5 migration: Forms

This has also been covered in the readme.

Closes: #50

@DionPotkamp DionPotkamp changed the title add bootstrap 5 Components Add bootstrap 5 Components Jun 15, 2021
@DionPotkamp DionPotkamp marked this pull request as ready for review June 16, 2021 11:33
@DionPotkamp DionPotkamp changed the title Add bootstrap 5 Components Support for Bootstrap v5 Jun 16, 2021
@mustafa-online
Copy link

Can't wait for this to be merged 😍✨ thanks a lot @DionPotkamp

Dion Potkamp added 2 commits June 22, 2021 12:15
including: color, range, switch
If bound the value would incorrectly be #000000
Copy link

@simtabi simtabi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please merge for bootstrap 5 support

@freezy-sk
Copy link

@pascalbaljet please merge this 🙏🏻

@ArtMin96
Copy link

Any news?

@freezy-sk
Copy link

until this PR will be merged, you can use it by adding forked repository to your composer.json and requiring this pull requested branch.

composer.json

 "require": { ... "protonemedia/laravel-form-components": "dev-bootstrap-v5", ... }, "repositories": [ { "type": "vcs", "url": "git@github.com:DionPotkamp/laravel-form-components.git" } ], 
@pascalbaljet
Copy link
Contributor

Hey everybody! I'll take a look at this PR as soon as possible, hopefully within a week. I was a bit preoccupied with the other projects 😅

@mustafa-online
Copy link

@pascalbaljet
any progress on this? 😢

@pascalbaljet pascalbaljet merged commit 88e5735 into protonemedia:master Sep 8, 2021
@pascalbaljet
Copy link
Contributor

I just tagged v3 with support for Bootstrap 5. Special thanks to @DionPotkamp for this PR!

@freezy-sk
Copy link

freezy-sk commented Sep 8, 2021

@pascalbaljet please release it as 2.6.0
It's not breaking changes so according to semantic versioning there is no need to increment major version.
With 2.6.0 it can be installed just by running composer update. With 3.0.0 everyone must change ^2.5.0 to ^3.0.0 and then run update.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

6 participants