Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -628,24 +628,35 @@ func (gr *GenericResources) IsItemCompleted(aw *arbv1.AppWrapperGenericResource,
if err != nil {
klog.Errorf("Error listing object: ", err)
}
//ignore if object listing failed
if inEtcd == nil {
klog.Errorf("Unable to retrieve unstructured objects to check completion status")
return false
}

for _, job := range inEtcd.Items {
completionRequiredBlock := aw.CompletionStatus
if len(completionRequiredBlock) > 0 {
//klog.V(4).Infof("Checking completion status for genericItem: %v in namespace: %v with labels: %v", aw.Name, namespace, aw.Labels)
unstructuredObjectName := job.GetName()
//ignore nil object
if len(completionRequiredBlock) > 0 && len(unstructuredObjectName) > 0 {
klog.V(4).Infof("Unmarshalling object %v for checking completion status", unstructuredObjectName)
conditions, err := job.Object["status"].(map[string]interface{})["conditions"].([]interface{})
//if condition not found skip for this interation
//TODO: process error gracefully as error could be due to user error
if err {
klog.Errorf("Error processing unstructured object")
}

for _, item := range conditions {
completionType := fmt.Sprint(item.(map[string]interface{})["type"])
//Move this to utils package?
userSpecfiedCompletionConditions := strings.Split(aw.CompletionStatus, ",")
for _, condition := range userSpecfiedCompletionConditions {
if strings.Contains(strings.ToLower(completionType), strings.ToLower(condition)) {
return true
if len(conditions) > 0 {
for _, item := range conditions {
completionType := fmt.Sprint(item.(map[string]interface{})["type"])
//Move this to utils package?
userSpecfiedCompletionConditions := strings.Split(aw.CompletionStatus, ",")
for _, condition := range userSpecfiedCompletionConditions {
if strings.Contains(strings.ToLower(completionType), strings.ToLower(condition)) {
return true
}
}
}
}
Expand Down