Skip to content

improve Logger #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 25, 2017
Merged

improve Logger #86

merged 6 commits into from
Oct 25, 2017

Conversation

@yiming-tang-cs
Copy link
Contributor

@yiming-tang-cs yiming-tang-cs commented Oct 20, 2017 •
edited by khatchad
Loading

#70
@khatchad
Copy link
Member

khatchad commented Oct 20, 2017

Are we sure these are all the places where loggers are used?
@yiming-tang-cs
Copy link
Contributor Author

yiming-tang-cs commented Oct 20, 2017

There are two Loggers from another two projects: WALA and SAFE. I am not sure whether you need to change it.
@khatchad
Copy link
Member

khatchad commented Oct 20, 2017

Nope, we can keep those.
@khatchad
Copy link
Member

khatchad commented Oct 20, 2017

How about these?

edu.cuny.hunter.streamrefactoring.core/src/edu/cuny/hunter/streamrefactoring/core/safe/InstructionBasedSolver.java:	Logger.getGlobal().info("Examining instance: " + instanceKey); edu.cuny.hunter.streamrefactoring.core/src/edu/cuny/hunter/streamrefactoring/core/safe/InstructionBasedSolver.java:	Logger.getGlobal().info("Tracking: " + ret);
khatchad
khatchad requested changes Oct 20, 2017
View reviewed changes
Copy link
Member

@khatchad khatchad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also change these?

edu.cuny.hunter.streamrefactoring.core/src/edu/cuny/hunter/streamrefactoring/core/safe/InstructionBasedSolver.java:	Logger.getGlobal().info("Examining instance: " + instanceKey); edu.cuny.hunter.streamrefactoring.core/src/edu/cuny/hunter/streamrefactoring/core/safe/InstructionBasedSolver.java:	Logger.getGlobal().info("Tracking: " + ret);
...mrefactoring.core/src/edu/cuny/hunter/streamrefactoring/core/analysis/OrderingInference.java Outdated
Copy link
Member

@khatchad khatchad Oct 20, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make this string a constant, say in the "core" plugin?
Copy link
Member

@khatchad khatchad Oct 20, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In fact, that string may be around somewhere. Please search for it.
khatchad
khatchad requested changes Oct 20, 2017
View reviewed changes
Copy link
Member

@khatchad khatchad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about these?

edu.cuny.hunter.streamrefactoring.core/src/edu/cuny/hunter/streamrefactoring/core/safe/InstructionBasedSolver.java:	Logger.getGlobal().info("Examining instance: " + instanceKey); edu.cuny.hunter.streamrefactoring.core/src/edu/cuny/hunter/streamrefactoring/core/safe/InstructionBasedSolver.java:	Logger.getGlobal().info("Tracking: " + ret);
...mrefactoring.core/src/edu/cuny/hunter/streamrefactoring/core/analysis/OrderingInference.java Outdated
Copy link
Member

@khatchad khatchad Oct 20, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In fact, that string may be around somewhere. Please search for it.
yiming-tang-cs
yiming-tang-cs commented Oct 23, 2017
View reviewed changes
...ter.streamrefactoring.core/src/edu/cuny/hunter/streamrefactoring/core/analysis/Packages.java Outdated
Copy link
Contributor Author

@yiming-tang-cs yiming-tang-cs Oct 23, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean adding constant like this?
Copy link
Contributor Author

@yiming-tang-cs yiming-tang-cs Oct 23, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just changed the getGobal() into getLogger(Packages.streamRefactoring);. If this is what you want, I will change all getLogger("edu.cuny.hunter.streamrefactoring") into getLogger(Packages.streamRefactoring);.

Sorry for the late commits.
Copy link
Member

@khatchad khatchad Oct 24, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about a Constants class in the edu.cuny.hunter.streamrefactoring.core.util package?
khatchad
khatchad requested changes Oct 24, 2017
View reviewed changes
....hunter.streamrefactoring.core/src/edu/cuny/hunter/streamrefactoring/core/analysis/Util.java Outdated
Copy link
Member

@khatchad khatchad Oct 24, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the constant here.
...refactoring.core/src/edu/cuny/hunter/streamrefactoring/core/safe/InstructionBasedSolver.java Outdated
Copy link
Member

@khatchad khatchad Oct 24, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can the logger be a field like the others?
...amrefactoring.core/src/edu/cuny/hunter/streamrefactoring/core/safe/ModifiedBenignOracle.java Outdated
Copy link
Member

@khatchad khatchad Oct 24, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Field here as well?
khatchad
khatchad requested changes Oct 24, 2017
View reviewed changes
...hunter.streamrefactoring.core/src/edu/cuny/hunter/streamrefactoring/core/utils/Packages.java Outdated
Copy link
Member

@khatchad khatchad Oct 24, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is a package?
...hunter.streamrefactoring.core/src/edu/cuny/hunter/streamrefactoring/core/utils/Packages.java Outdated
Copy link
Member

@khatchad khatchad Oct 24, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about something like LOGGER_NAME?
@khatchad khatchad changed the title improve Logger #70 improve Logger Oct 24, 2017
@yiming-tang-cs
Copy link
Contributor Author

yiming-tang-cs commented Oct 25, 2017

What is a package?

I thought the new class stores a list of constants for the package names, so I used Packages as a class name. How about the current class name: LoggerNames?
@khatchad
Copy link
Member

khatchad commented Oct 25, 2017

What is a package?

I thought the new class stores a list of constants for the package names, so I used Packages as a class name. How about the current class name: LoggerNames?

Ah, I guess we could have individual loggers for packages, but I think one logger for the entire thing is okay for now. Yes, LoggerNames sounds good.
@khatchad khatchad merged commit 9e0b28d into ponder-lab:master Oct 25, 2017
@khatchad khatchad deleted the issue_70 branch October 25, 2017 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@yiming-tang-cs @khatchad