Skip to content

Conversation

@khatchad
Copy link
Member

No description provided.

@yiming-tang-cs
Copy link
Contributor

Does this fix #119?

@yiming-tang-cs
Copy link
Contributor

Fixing #119 is a task in Asana and I just want to make sure there is no duplicate task.

@khatchad
Copy link
Member Author

This is just a pull request. It's not meant to fix an issue but rather pull code into the main line. Do you mean that if one of the issues covered in this pull request fixes #119?

@yiming-tang-cs
Copy link
Contributor

Do you mean that if one of the issues covered in this pull request fixes #119?

It seems no...I just asked...

@khatchad
Copy link
Member Author

Do you mean that if one of the issues covered in this pull request fixes #119?

It seems no...I just asked...

@saledouble No problem. No, it doesn't include a fix for #119. The main commit is 05d53ee.

@khatchad khatchad merged commit eb6d945 into master Dec 21, 2017
@khatchad khatchad deleted the missing_entry_points branch December 21, 2017 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants