- Notifications
You must be signed in to change notification settings - Fork 7
Add test cases for issue 122 #131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please format the test input files.
| @@ -0,0 +1,20 @@ | |||
| package p; | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the purpose of this test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this test case, n() has a dependency on m(), but in the first test case, n() and m() are independent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. In an effort to reduce test time, let's keep the file but remove it from the test case.
| @@ -0,0 +1,23 @@ | |||
| package p; | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the purpose of this test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just follow your instruction: " For the case created above, create another case by copying the above but removing one of the @entrypoint annotations." #122
I guess you want to create a comparison for the test case with multiple entry points.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. I don't think we need a case with a dependency between the two methods. I'm unsure as to what that is going to buy us. Please let me know if you disagree.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK.
| @@ -0,0 +1,20 @@ | |||
| package p; | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. In an effort to reduce test time, let's keep the file but remove it from the test case.
| @@ -0,0 +1,23 @@ | |||
| package p; | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. I don't think we need a case with a dependency between the two methods. I'm unsure as to what that is going to buy us. Please let me know if you disagree.
#122