Skip to content

Conversation

@yiming-tang-cs
Copy link
Contributor

@yiming-tang-cs yiming-tang-cs commented Dec 19, 2017

@yiming-tang-cs yiming-tang-cs changed the title Issue 122 Add test cases for issue 122 Dec 19, 2017
Copy link
Member

@khatchad khatchad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please format the test input files.

@@ -0,0 +1,20 @@
package p;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the purpose of this test?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this test case, n() has a dependency on m(), but in the first test case, n() and m() are independent.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. In an effort to reduce test time, let's keep the file but remove it from the test case.

@@ -0,0 +1,23 @@
package p;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the purpose of this test?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just follow your instruction: " For the case created above, create another case by copying the above but removing one of the @entrypoint annotations." #122
I guess you want to create a comparison for the test case with multiple entry points.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. I don't think we need a case with a dependency between the two methods. I'm unsure as to what that is going to buy us. Please let me know if you disagree.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK.

@@ -0,0 +1,20 @@
package p;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. In an effort to reduce test time, let's keep the file but remove it from the test case.

@@ -0,0 +1,23 @@
package p;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. I don't think we need a case with a dependency between the two methods. I'm unsure as to what that is going to buy us. Please let me know if you disagree.

@khatchad khatchad merged commit dc85fd0 into ponder-lab:master Dec 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants