Created WebGL heatmap doc for R API #998
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
bcdunbar reviewed Aug 6, 2018
Contributor
bcdunbar left a comment
bcdunbar left a comment There was a problem hiding this comment.
Looks good. I'd just define the colors a little more (see comment).
| | ||
| p <- plot_ly( | ||
| z = zdata, | ||
| colorscale = list(c(0,1),c("rgb(155,112,184)","rgb(128,100,64)")), |
Contributor
There was a problem hiding this comment.
I'd probably make the colors pop a little more, something like you have but colorscale = list(c(0,0.5,1),c("blue", "white", "red"))
Contributor Author
There was a problem hiding this comment.
Thanks! @bcdunbar I have changed them to the suggested colorscale.
Contributor
| @priyatharsan Great 👍 lgtm 💃 |
Contributor Author
| Thanks! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
R tutorial for WebGL Heatmap created with ref to issue #740
@cldougl @bcdunbar