Skip to content

Fix: exclude nested .vscode directories from package publish #5239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fix: exclude nested .vscode directories from package publish #5239

wants to merge 1 commit into from

Conversation

@ritesh006
Copy link

@ritesh006 ritesh006 commented Aug 29, 2025

Fixes #5160

Problem:
pio pkg pack/publish included .vscode directories inside subfolders
(e.g. examples), even though the top-level .vscode was excluded.

Change:
Added **/.vscode/ (and normalized .vscode/ with trailing slash) to
EXCLUDE_DEFAULT. This mirrors .pio handling and ensures both top-level
and nested .vscode folders are excluded automatically.

Manual test:

  • Created test package with examples/blink/.vscode/settings.json
  • Before patch: file appeared in tarball
  • After patch: .vscode excluded from tarball
@ritesh006
Copy link
Author

ritesh006 commented Sep 8, 2025

could anyone please review this?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant

@ritesh006