Skip to content

Conversation

@mortada
Copy link
Contributor

@mortada mortada commented Apr 11, 2015

as discussed in #9667

@jorisvandenbossche please take a look, thanks

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe "column names" instead of "columns"?

@mortada
Copy link
Contributor Author

mortada commented Apr 11, 2015

@shoyer good idea, it's updated

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quote .str with two backticks?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just "whitespace", I think

@shoyer
Copy link
Member

shoyer commented Apr 11, 2015

This looks great to me! I'll just hold off on merging until Joris can take a look.

@jorisvandenbossche
Copy link
Member

Looks good, thanks a lot!

jorisvandenbossche added a commit that referenced this pull request Apr 12, 2015
DOC: add more examples to StringMethods on Index
@jorisvandenbossche jorisvandenbossche merged commit f5b4775 into pandas-dev:master Apr 12, 2015
@mortada mortada deleted the index_str_docs branch April 13, 2015 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants