Skip to content

PERF: Switch to try/except in extract() rather than instance check #8202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

PERF: Switch to try/except in extract() rather than instance check #8202

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
PERF: switch to faster try/except in extract() 
isinstance check takes longer but accomplishes the same thing.
  • Loading branch information
@jtratner
jtratner committed Sep 7, 2014
commit b209a5106f94f9123a50d7e9187e076ab7ead7ab
4 changes: 3 additions & 1 deletion pandas/core/strings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -465,7 +465,9 @@ def str_extract(arr, pat, flags=0):
raise ValueError("This pattern contains no groups to capture.")
empty_row = [np.nan]*regex.groups
def f(x):
if not isinstance(x, compat.string_types):
try:
regex.search(x)
except TypeError:
return empty_row
m = regex.search(x)
if m:
Expand Down