STY: Add explicit strict= to zip() calls in pandas/tests/strings #63353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Add strict=True or strict=False to all zip() calls in pandas/tests/strings/ to comply with Ruff rule B905 (zip-without-explicit-strict). - conftest.py: Add strict=False for intentionally unequal length zip, strict=True for equal length unpack - test_api.py: Add strict=True for equal length unpack - test_strings.py: Add strict=True for equal length strings Partial fix for pandas-dev#62434 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Summary
Add
strict=Trueorstrict=Falseto allzip()calls inpandas/tests/strings/directory to comply with Ruff rule B905 (zip-without-explicit-strict).Changes
conftest.pystrict=Falsefor intentionally unequal length zip,strict=Truefor equal length unpacktest_api.pystrict=Truefor equal length unpacktest_strings.pystrict=Truefor equal length stringsDetails
conftest.pyline 97: Usesstrict=Falsebecause the zip intentionally combines a list of ~27 methods with[()] * 100and[{}] * 100(unequal lengths by design)conftest.pyline 100: Usesstrict=Truebecause unpacking_any_string_methodwhere each element is a 3-tupletest_api.pyline 24: Usesstrict=Truebecause unpacking_any_allowed_skipna_inferred_dtypewhere each element is a 2-tupletest_strings.pyline 760: Usesstrict=Truebecausezip("abc", "def")combines two equal-length stringsPartial fix for #62434
🤖 Generated with Claude Code