Skip to content

check for np.str_ when checking strings #63029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

check for np.str_ when checking strings #63029

wants to merge 1 commit into from
+2 −2

Conversation

@antareepsarkar
Copy link

@antareepsarkar antareepsarkar commented Nov 7, 2025

Description

This adds checking for the type np.str_ when checking for strings in core.dtypes.inference.

Motivation

Got the idea when came to know about np.str_
mroeschke
mroeschke requested changes Nov 7, 2025
View reviewed changes
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, but could you show an example with a public pandas API where this change is needed?
@jbrockmendel
Copy link
Member

jbrockmendel commented Nov 7, 2025

np.str_ subclasses str, so hard to see how this can make a difference
@antareepsarkar
Copy link
Author

antareepsarkar commented Nov 8, 2025 •
edited
Loading

Yes, np.str_ inherits str. I should have checked. Sorry for that.
Probably, this change is not required.
@mroeschke
Copy link
Member

mroeschke commented Nov 8, 2025

OK going to close then
@mroeschke mroeschke closed this Nov 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@antareepsarkar @jbrockmendel @mroeschke