Skip to content

Conversation

@jbrockmendel
Copy link
Member

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

This came up here. This casting is unnecessary and doesn't match the DataFrame.combine_first behavior. Let's deprecate it.

@mroeschke mroeschke added Deprecate Functionality to remove in pandas combine/combine_first/update NDFrame.combine, combine_first, update labels Oct 31, 2025
@mroeschke mroeschke added this to the 3.0 milestone Oct 31, 2025
@mroeschke mroeschke merged commit bdc9a7b into pandas-dev:main Oct 31, 2025
52 checks passed
@mroeschke
Copy link
Member

Thanks @jbrockmendel

@jbrockmendel jbrockmendel deleted the depr-combine_first-casting branch October 31, 2025 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

combine/combine_first/update NDFrame.combine, combine_first, update Deprecate Functionality to remove in pandas

2 participants