BUG: Aligned skew and kurt results with scipy.stats #62925
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
added 9 commits October 29, 2025 21:33
SebastianGoldmann changed the title 
Alvaro-Kothe reviewed Nov 2, 2025
| result = s.sem(ddof=1) | ||
| assert pd.isna(result) | ||
| | ||
| def test_skew(self): |
There was a problem hiding this comment.
Why are you removing this test?
There was a problem hiding this comment.
HI Alvaro,
Thank you for the review.
In my previous commit I thought these were duplicated tests, but looking at it again these should not be removed. I will revert and update the tests.
| alt = lambda x: sp_stats.kurtosis(x, bias=False) | ||
| self._check_stat_op("kurt", alt, string_series) | ||
| | ||
| def test_kurt_corner(self): |
There was a problem hiding this comment.
Why are you removing this test?
Comment on lines 560 to +565
| # fix for handling cases where all elements in an axis are the same | ||
| if isinstance(result, np.ndarray): | ||
| result[np.max(values, axis=axis) == np.min(values, axis=axis)] = 0 | ||
| result[np.max(values, axis=axis) == np.min(values, axis=axis)] = np.nan | ||
| return result | ||
| elif np.max(values) == np.min(values): | ||
| return 0.0 | ||
| return np.nan |
There was a problem hiding this comment.
I think these branches can be removed, since SciPy already assigns NaN.
Suggested change
| # fix for handling cases where all elements in an axis are the same | |
| if isinstance(result, np.ndarray): | |
| result[np.max(values, axis=axis) == np.min(values, axis=axis)] = 0 | |
| result[np.max(values, axis=axis) == np.min(values, axis=axis)] = np.nan | |
| return result | |
| elif np.max(values) == np.min(values): | |
| return 0.0 | |
| return np.nan |
Co-authored-by: Álvaro Kothe <kothe65@gmail.com>
Co-authored-by: Álvaro Kothe <kothe65@gmail.com>
Co-authored-by: Álvaro Kothe <kothe65@gmail.com>
Co-authored-by: Álvaro Kothe <kothe65@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Rolling.{skew,kurt}for degenerate distributions #62864 (Replace xxxx with the GitHub issue number)doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.