ENH: add option to save json without escaping forward slashes #62830
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…e escape_forward_slashes is False
| pre-commit.ci autofix |
for more information, see https://pre-commit.ci
…m/zephyrieal/pandas into 61442-json-escape-forward-slashes
| Hi, the test for Pandas for Pyodide is failing, I'm not sure why because the parts of the repository it relates to I haven't changed. Is this an issue that requires changes in my code to fix? |
| assert result == expected | ||
| | ||
| | ||
| def test_to_json_escape_forward_slashes(): |
There was a problem hiding this comment.
Can you create a test that also escapes forward slash?
| ) as handles: | ||
| handles.handle.write(s) | ||
| else: | ||
| if not escape_forward_slashes: |
There was a problem hiding this comment.
This will only apply if you are not writing to a file.
| for letter in s: | ||
| if skip is False: | ||
| if letter + s[i] == pattern: | ||
| new_s = new_s + r"/" |
There was a problem hiding this comment.
For me, this shouldn't be done in python as a post-processing step. Ideally, you should change the behavior on the C implementation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.Added code in the to_json() function in pandas/io/json/__json.py file.
Will replace escaped forward slashes with forward slashes if escape_forward_slashes parameter is set to False.
Particularly useful for file paths, so the path doesn't get changed.