DEPR: rename filter->select #62684
Open
DEPR: rename filter->select #62684
+117 −83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
rhshadrach requested changes Oct 15, 2025
There was a problem hiding this comment.
My preference here would be to remove the axis argument and have select only operate on columns, which would agree with PySpark and Polars. We could point users to using .loc for operating on rows (regex and like can be done via boolean masks as well). But I won't block on this.
Comment on lines 266 to 272
| :meth:`Series.select` and :meth:`DataFrame.select` | ||
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
| | ||
| The ``filter`` method is used to select a subset of rows that match certain criteria. | ||
| :meth:`Series.filter` and :meth:`DataFrame.filter` do not support user defined functions, | ||
| The ``select`` method is used to select a subset of rows that match certain criteria. | ||
| :meth:`Series.select` and :meth:`DataFrame.select` do not support user defined functions, | ||
| but :meth:`SeriesGroupBy.filter` and :meth:`DataFrameGroupBy.filter` do. You can read more | ||
| about ``filter`` in groupby operations in :ref:`groupby.filter`. |
There was a problem hiding this comment.
This section was really about groupby's filter (which is already filter-y). We only gave a head nod to other filters just because they had the same name so as not to cause confusion. Can we either just add that Series.filter and DataFrame.filter are deprecated or remove the lines about Series.filter and DataFrame.filter entirely.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.cc @jorisvandenbossche want to make sure this doesn't catch you by surprise. To avoid API bikeshedding, this just renames filter->select without futzing with the signature etc. AFAICT the real benefit is going to be in freeing up "filter" to be eventually re-implemented to be actually filter-y.