TST: replace ensure_clean with temp_file on pandas/tests/io/xml/test_xml.py #62638
+36 −27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
mroeschke approved these changes Oct 9, 2025
mroeschke reviewed Oct 9, 2025
| | ||
| def test_compression_read(parser, compression_only): | ||
| def test_compression_read(parser, compression_only, temp_file): | ||
| with tm.ensure_clean() as comp_path: |
There was a problem hiding this comment.
Can you replace this too (by using tmp_path)?
There was a problem hiding this comment.
Ah sorry I missed a couple of ensure_clean() functions on this file. Will put the PR on draft until I commit the changes needed for this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
ensure_cleanutility function with thetemp_filepytest fixture #62435 (Replace xxxx with the GitHub issue number)Added type annotations to new arguments/methods/functions.Added an entry in the latestdoc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.