Fix: Indexing with dates of higher resolution should return empty #62607
+15 −13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
suzyahyah force-pushed the fix_datetime_indexing_emptyslice branch 4 times, most recently from 5cc24d3 to 628583d Compare 
…ce instead raising KeyError
suzyahyah force-pushed the fix_datetime_indexing_emptyslice branch from 628583d to 35c218d Compare 
| Thanks for the PR. I'm somewhat hesitant to do this without a deprecation cycle as I think people could rely on the standing behavior in their code, but let's see what @jorisvandenbossche thinks |
| @jbrockmendel it seems like youre working on something similar with .loc indexing? |
Not sure what you're referring to, no. I don't think the title is accurate. This isn't about the resolution of anything. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Indexing with out of range datetime objects of higher resolution should return empty slice instead of raising KeyError.
This is to be "consistent with normal slicing, where out of range slice bounds return an empty object, and don't raise an error".
As per this issue 25803, specifically #25803 (comment), if the date is of higher resolution than the current object in the series, e.g., day>minutes, then the empty slice should be returned instead of KeyError.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.