STY: Use strict arg in zip() in pandas/core/reshape #62483
+33 −31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Alvaro-Kothe suggested changes Sep 28, 2025
| @jsngn can you merge main and see if you can address the failing tests |
| @jbrockmendel Still failing on errors that are seemingly unrelated to my PR, I'm not sure why |
| Some of those are unrelated and hopefully will resolve themselves next time you push to the branch. Others look real: |
| Thanks for calling my attention to the issues. PR is passing now, please re-review, thank you! @Alvaro-Kothe @jbrockmendel |
| | ||
| for col, pre, sep in zip(data_to_encode.items(), prefix, prefix_sep): | ||
| for col, pre, sep in zip( | ||
| data_to_encode.items(), prefix, prefix_sep, strict=False |
There was a problem hiding this comment.
I think it is possible to make strict=True if prefix and prefix_sep aren't an infinite generator created with itertools.cycle.
| levs = ( | ||
| [lev[c] if c >= 0 else None for c in codes] | ||
| for lev, codes in zip(columns.levels[:-1], columns.codes[:-1]) | ||
| for lev, codes in zip(columns.levels[:-1], columns.codes[:-1], strict=False) |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Tests added and passed if fixing a bug or adding a new featurenot applicableAdded type annotations to new arguments/methods/functions.not applicableAdded an entry in the latestnot applicabledoc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.